Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remote mods directory #403

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

Alystrasz
Copy link
Contributor

This pull request introduces remote mods folder, located at /runtime/remote/mods, that will store future auto-installed mods.

In short, it's the "mods need to pull from 2 folders, local (user-installed) and remote (auto-installed)" mentioned by @BobTheBob9 in #396.

Changes
  • Creates remote mod directory if it does not exist;
  • When loading mods, check local folder AND remote mod folder

(note: there was already a REMOTE_MOD_FOLDER_SUFFIX variable in code, I simply added some stuff around to use it)

Copy link
Member

@BobTheBob9 BobTheBob9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great and shouldn't create any different behaviour between the different mod dirs due to how we store mods at runtime

@Alystrasz Alystrasz mentioned this pull request Jan 27, 2023
8 tasks
@BobTheBob9 BobTheBob9 merged commit d418217 into R2Northstar:main Jan 30, 2023
@Alystrasz Alystrasz deleted the feat/remote-mods-directory branch January 30, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants