Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mods validation #74

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Alystrasz
Copy link
Contributor

@Alystrasz Alystrasz commented Sep 2, 2022

  • Mention Thunderstore publish GitHub action
  • Lists actions needed for a mod to be verified
TODOs
  • Decide requirements needed to validate a mod
  • Merge MS and Launcher PRs

Related pull requests

Master server: R2Northstar/NorthstarMasterServer#87
Launcher: R2Northstar/NorthstarLauncher#262

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might also wanna mention somewhere that only client side mods that are required by server are eligible for verification as the only point for verification is to basically quick install mods.

So it makes no sense IMO to verify client-only mods like skins or server-only mods like Fifty.ServerUtils. ^^

docs/source/guides/publishing.rst Outdated Show resolved Hide resolved
@Alystrasz
Copy link
Contributor Author

We might also wanna mention somewhere that only client side mods that are required by server are eligible for verification as the only point for verification is to basically quick install mods.

So it makes no sense IMO to verify client-only mods like skins or server-only mods like Fifty.ServerUtils. ^^

It's already mentioned there: "If you server requires client-side mods, when people connect to it, they will see this kind of message:" :)
To be sure message is understood, I added a note in b8cbb38.

@emma-miler emma-miler added the waiting for author This PR/Issue is waiting for it's author. label Nov 13, 2022
@Alystrasz
Copy link
Contributor Author

More than waiting for author, this is waiting for general consensus on verified mods.
@GeckoEidechse wanna bring the hot topic on the table again? 😄

@Alystrasz
Copy link
Contributor Author

@GeckoEidechse 2 things before I update this PR:

  1. Could you create a repo to list verified mods? I plan to link it in this documentation PR to tell people how to create PRs to submit their mods to verification
  2. Should we move NSModTemplate to R2NorthstarTools, so we can officially recommand it for verified mods?

@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 20, 2023
@GeckoEidechse
Copy link
Member

bump ^^

@Alystrasz Alystrasz marked this pull request as ready for review January 24, 2024 19:01
@github-actions github-actions bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jan 26, 2024
@github-actions github-actions bot added merge conflicts Blocked by merge conflicts, waiting on the author to resolve and removed merge conflicts Blocked by merge conflicts, waiting on the author to resolve labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for author This PR/Issue is waiting for it's author.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants