Improved: changed the variable name that checks the auto generation o…

…f facilityId(hotwax#265)
R-Sourabh · Nov 20, 2024 · 5206c2c · 5206c2c
1 parent 6352f8e
commit 5206c2c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/src/components/CreateVirtualFacilityModal.vue b/src/components/CreateVirtualFacilityModal.vue
@@ -91,12 +91,12 @@ export default defineComponent({
         facilityId: '',
         description: '',
       },
-      isVirtualFacIdManuallySet: false
+      isAutoGenerateId: true
     }
   },
   methods: {
     setFacilityId(event: any) {
-      if(!this.isVirtualFacIdManuallySet) {
+      if(this.isAutoGenerateId) {
         this.formData.facilityId = generateInternalId(event.target.value)
       }
     },
@@ -160,7 +160,7 @@ export default defineComponent({
       this.formData.facilityId.length <= 20
         ? (this as any).$refs.facilityId.$el.classList.add('ion-valid')
         : (this as any).$refs.facilityId.$el.classList.add('ion-invalid');
-      this.isVirtualFacIdManuallySet = true;
+      this.isAutoGenerateId = false;
     },
     markFacilityIdTouched() {
       (this as any).$refs.facilityId.$el.classList.add('ion-touched');

diff --git a/src/views/CreateFacility.vue b/src/views/CreateFacility.vue
@@ -111,7 +111,7 @@ export default defineComponent({
       },
       selectedFacilityTypeId: '' as any,
       facilityTypesByParentTypeId: {} as any,
-      isFacilityIdManuallySet: false,
+      isAutoGenerateId: true,
     }
   },
   async ionViewWillEnter() {
@@ -139,10 +139,10 @@ export default defineComponent({
         facilityId: '',
         externalId: '',
       }
-      this.isFacilityIdManuallySet = false;
+      this.isAutoGenerateId = true;
     },
     setFacilityId(event: any) {
-      if(!this.isFacilityIdManuallySet) {
+      if(this.isAutoGenerateId) {
         this.formData.facilityId = generateInternalId(event.target.value)
       }
     },
@@ -218,7 +218,7 @@ export default defineComponent({
       this.formData.facilityId.length <= 20
         ? (this as any).$refs.facilityId.$el.classList.add('ion-valid')
         : (this as any).$refs.facilityId.$el.classList.add('ion-invalid');
-      this.isFacilityIdManuallySet = true;
+      this.isAutoGenerateId = false;
     },
     markFacilityIdTouched() {
       (this as any).$refs.facilityId.$el.classList.add('ion-touched');

diff --git a/src/views/CreateFacilityGroup.vue b/src/views/CreateFacilityGroup.vue
@@ -131,7 +131,7 @@ export default defineComponent({
       },
       isFacilityGroupTypeDisabled: false,
       selectedProductStoreIds: [],
-      isFacilityGroupIdManuallySet: false
+      isAutoGenerateId: true
     }
   },
   props: ['selectedFacilityGroupTypeId'],
@@ -148,7 +148,7 @@ export default defineComponent({
       this.selectedProductStoreIds = selectedProductStoreIds
     },
     setFacilityGroupId(event: any) {
-      if(!this.isFacilityGroupIdManuallySet) {
+      if(this.isAutoGenerateId) {
         this.formData.facilityGroupId = generateInternalId(event.target.value)
       }
     },
@@ -239,7 +239,7 @@ export default defineComponent({
       this.formData.facilityGroupId.length <= 20
         ? (this as any).$refs.facilityGroupId.$el.classList.add('ion-valid')
         : (this as any).$refs.facilityGroupId.$el.classList.add('ion-invalid');
-      this.isFacilityGroupIdManuallySet = true
+      this.isAutoGenerateId = false
     },
     markFacilityGroupIdTouched() {
       (this as any).$refs.facilityGroupId.$el.classList.add('ion-touched');