Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup and docs fixes #7272

Merged
merged 1 commit into from
Jan 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"prism-themes": "1.9.0",
"prismjs": "1.29.0",
"puppeteer": "22.13.1",
"qwik-image": "0.0.15",
"qwik-image": "0.0.16",
"react": "18.3.1",
"react-dom": "18.3.1",
"rehype-pretty-code": "0.11.0",
Expand Down
8 changes: 3 additions & 5 deletions packages/docs/src/repl/repl-output-update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,9 @@ const deepUpdate = (prev: any, next: any) => {
}
}
if (Array.isArray(prev)) {
for (const key in prev) {
if (!(key in next)) {
delete prev[key];
// deleting array elements doesn't change the length
prev.length--;
for (const item of prev) {
if (!next.includes(item)) {
prev.splice(prev.indexOf(item), 1);
}
}
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ describe('shared-serialization', () => {
it(title(TypeIds.Error), async () => {
const err = new Error('hi');
err.stack = err
.stack!.replaceAll(/\/.*\./g, '/...path/file.')
.stack!.replaceAll(/([A-Z]:){0,1}(\/|\\).*\./g, '/...path/file.')
.replaceAll(/:\d+:\d+/g, ':123:456');
expect(await dump(err)).toMatchInlineSnapshot(`
"
Expand Down
3 changes: 0 additions & 3 deletions packages/qwik/src/optimizer/core/src/inlined_fn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ pub fn convert_inlined_fn(
return (None, is_const);
}

println!("{:?}", is_used_as_object(&expr, &scoped_idents));

if !is_used_as_object(&expr, &scoped_idents) {
return (None, is_const);
}
Expand Down Expand Up @@ -218,7 +216,6 @@ impl<'a> Visit for ObjectUsageChecker<'a> {
if let ast::Expr::Ident(obj_ident) = &*node.obj {
for id in self.identifiers {
if obj_ident.sym == id.0 {
println!("Used as object: {:?}", obj_ident.sym);
self.used_as_object = true;
return;
}
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading