refactor(core): schedule QRLs instead of direct execution #7269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
🦋 Changeset detectedLatest commit: ec7e9b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
wmertens
changed the title
wmertens
force-pushed
the
remove-hW
branch
3 times, most recently
from
35a5079 to
75710de
Compare
Varixo
reviewed
Jan 20, 2025
this speeds up `pnpm build --qwik --dev` by a lot
get it from a different qrl instead
wmertens
force-pushed
the
remove-hW
branch
2 times, most recently
from
a3ffd65 to
bddac05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to call functions from core in QRLs, and uses it to schedule event handlers properly.
This removes the haphazard _hW exports from segments and replaces them with a single core export
_task.This is cleaner and allows core to provide qrl functions.