fix(dev): only inject css link tags that have js importers #7267
Conversation
|
thejackshelton
changed the title
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
it just adds it back every build
| const allModules = Array.from(server.moduleGraph.fileToModulesMap.entries()); | ||
|
|
||
| const CSS_EXTENSIONS = ['.css', '.scss', '.sass', '.less', '.styl', '.stylus']; | ||
| const JS_EXTENSIONS = ['.js', '.ts', '.tsx', '.jsx']; |
There was a problem hiding this comment.
there is also .mjs and everything with m
There was a problem hiding this comment.
also we need to escape the .
/\.
There was a problem hiding this comment.
both added as regexes now
| const added = new Set(); | ||
| const allModules = Array.from(server.moduleGraph.fileToModulesMap.entries()); | ||
|
|
||
| const CSS_EXTENSIONS = ['.css', '.scss', '.sass', '.less', '.styl', '.stylus']; |
There was a problem hiding this comment.
we should let the dev add or configure this just in-case the extensions change. but these are good defaults of course
There was a problem hiding this comment.
We'd need to modify the vite plugin API to do that. In which case we already plan to move the dev server to Qwik Router, so we should wait in this case before any API changes.
| @@ -3653,7 +3653,7 @@ Options for the prefetch service worker. | |||
| </tbody></table> | |||
| **Returns:** | |||
| [JSXNode](#jsxnode)<'script'> | |||
| JSXNode<'script'> | |||
There was a problem hiding this comment.
Please run pnpm api.update. Unfortunately the build messes with this.
| @@ -192,26 +199,11 @@ export async function configureDevServer( | |||
|
|
|||
| const result = await render(renderOpts); | |||
|
|
|||
| // Sometimes new CSS files are added after the initial render | |||
| Array.from(server.moduleGraph.fileToModulesMap.entries()).forEach((entry) => { | |||
There was a problem hiding this comment.
Aren't you now ignoring newly added css modules?
I think it would be better to generate the current list of css files on every update and make sure only those are injected?
wmertens
changed the title
Builds on top of #7266, otherwise I can't build Qwik.
Fixes #5965 in the Qwik vite dev server.