refactor: v2 release #6903

wmertens · 2024-09-22T19:36:11Z

This PR is for showing progress on v2, and having installable npm packages.

DO NOT MERGE

The changes are meant to be readable and maintainable, so if things are unclear please let us know.

changeset-bot · 2024-09-22T19:36:15Z

🦋 Changeset detected

Latest commit: d848ba5

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/qwik/src/core/v2/client/dom-container.ts

packages/qwik/src/core/v2/client/vnode.ts

pkg-pr-new · 2024-09-23T08:08:51Z

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@6903

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@6903

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@6903

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@6903

commit: d848ba5

github-actions · 2024-09-23T08:09:11Z

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
qwik-docs	✅ Ready (View Log)	Visit Preview	`d848ba5`

packages/qwik/src/core/client/dom-container.ts

+        }
+        errorDiv.setAttribute('q:key', '_error_');
+        const journal: VNodeJournal = [];
+        vnode_getDOMChildNodes(journal, vHost).forEach((child) => errorDiv.appendChild(child));


packages/qwik/src/core/client/vnode.ts

+        } else if (key === 'value' && key in element) {
+          (element as any).value = escapeHTML(String(value));
+        } else if (key === dangerouslySetInnerHTML) {
+          (element as any).innerHTML = value!;


To fix the problem, we need to ensure that any data assigned to innerHTML is properly sanitized to prevent XSS attacks. The best way to fix this without changing existing functionality is to use a function that escapes HTML special characters before assigning the value to innerHTML.

Import or define a function to escape HTML special characters.

Use this function to sanitize the value before assigning it to innerHTML.

packages/qwik/src/core/client/vnode.ts

+        const insertBefore = journal[idx++] as Element | Text | null;
+        let newChild: any;
+        while (idx < length && typeof (newChild = journal[idx]) !== 'number') {
+          insertParent.insertBefore(newChild, insertBefore);


fix(repl): unbreak

they are not being used

this avoids having to transpile the vite.config.mts file, which sometimes causes eslint errors during builds

fix(v2): various dev fixes

v2: make optimizer async + remove fs

feat(v2): add nesting error file location

V2 Version Packages (alpha)

chore: merge main

fix: wait for QRL to resolve for signal attribute

Revert "fix: wait for QRL to resolve for signal attribute"

fix: input's value is string when passing number

fix: convert destructured array's props to signal

fix(repl): resolve core/internal

…throw fix: retry vnode diffing on promise throw

fix: component props as var props

…atch error

feat: log a warning instead of throwing an error for server host mismatch error

chore: cleanup and docs fixes

Version Packages (alpha) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

wmertens added the VERSION: upcoming major label Sep 22, 2024

github-advanced-security bot found potential problems Sep 22, 2024

View reviewed changes

packages/qwik/src/core/v2/client/dom-container.ts Fixed Show fixed Hide fixed

packages/qwik/src/core/v2/client/vnode.ts Fixed Show fixed Hide fixed

packages/qwik/src/core/v2/client/vnode.ts Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Sep 26, 2024

View reviewed changes

wmertens changed the title ~~refactor: v2 framework rewrite~~ refactor: v2 release Oct 8, 2024

wmertens marked this pull request as ready for review October 17, 2024 21:25

wmertens requested review from a team as code owners October 17, 2024 21:25

wmertens mentioned this pull request Oct 29, 2024

Why does this not publish PR packages? stackblitz-labs/pkg.pr.new#270

Closed

wmertens added 8 commits November 1, 2024 12:15

fix(repl): make it build again

69d1e8b

chore(repl): better playground starting point

4ccb6f1

Merge pull request #7031 from QwikDev/v2-fix-repl

5cce1b1

fix(repl): unbreak

fix(core): add keys to jsxnodes when needed

74c1e57

perf(optimizer): parallel transformation

b9ea512

chore(optimizer): remove fs and parallel features

de3052f

they are not being used

fix(dev): prevent vite from putting v1 in optimizeDeps

8594ced

perf(docs): configure optimizeDeps

3727a8e

wmertens mentioned this pull request Nov 4, 2024

Support tag for release stackblitz-labs/pkg.pr.new#169

Closed

Varixo and others added 9 commits November 4, 2024 15:07

add nesting error file location

e24f321

chore(docs, insights): make ESM projects

add0279

this avoids having to transpile the vite.config.mts file, which sometimes causes eslint errors during builds

docs(glob-import): update for v2

6688f2d

chore: pnpm docs.sync

2d48253

chore: pnpm api.update

0c8a08a

Merge pull request #7042 from QwikDev/v2-fix-dev

a8b8dee

fix(v2): various dev fixes

Merge pull request #7040 from QwikDev/async-optimizer

bd98e33

v2: make optimizer async + remove fs

Merge pull request #7043 from QwikDev/v2-nesting-error-file-location

39df9c4

feat(v2): add nesting error file location

remove keys logic from matchers

c363ca3

github-actions bot and others added 30 commits January 10, 2025 19:00

Version Packages (alpha)

5a911ea

Merge pull request #7192 from QwikDev/changeset-release/build/v2

cb53bbd

V2 Version Packages (alpha)

ci(V2): trying to solve auto tag alpha release to latest

34831cf

Merge branch 'build/v2' into v2v2v2

ab81e32

fix

c85acbb

Merge branch 'v2v2v2' of https://github.com/JerryWu1234/qwik into v2v2v2

96c0105

Merge branch 'main' into v2-merge-main-10-01

9ee46c1

fix: build & e2e test after merge

226a043

chore: remove v1 changesets

9d6c72d

chore: update rust snapshots

6dbf6c8

Merge pull request #7242 from QwikDev/v2-merge-main-10-01

93e5664

chore: merge main

fix: wait for QRL to resolve for signal attribute

a5d6d7e

Merge pull request #7243 from QwikDev/v2-signal-prop-qrl

ccd3534

fix: wait for QRL to resolve for signal attribute

Revert "fix: wait for QRL to resolve for signal attribute"

2f8cec9

Merge pull request #7246 from QwikDev/revert-7243-v2-signal-prop-qrl

cae8268

Revert "fix: wait for QRL to resolve for signal attribute"

Merge pull request #7182 from JerryWu1234/v2v2v2

42a6c35

fix: input's value is string when passing number

Merge pull request #7217 from QwikDev/v2-fix-wrapeed-indentifiers

66529fc

fix: convert destructured array's props to signal

fix(repl): resolve core/internal

c138449

Merge pull request #7258 from QwikDev/fix-repl

ad4444c

fix(repl): resolve core/internal

fix: retry vnode diffing on promise throw

dc08212

chore: flatPromise not needed

3f4af53

Merge pull request #7259 from QwikDev/v2-retry-vnode-diff-on-promise-…

9b92141

…throw fix: retry vnode diffing on promise throw

fix: component props as var props

fe8c395

Merge pull request #7265 from QwikDev/v2-props-as-var-props

cb22f46

fix: component props as var props

feat: log a warning instead of throwing an error for server host mism…

50adb35

…atch error

feat: add ssrNodeDocumentPosition function

e0bc963

Merge pull request #7236 from QwikDev/v2-warn-server-mismatch-error

bd9dbf1

feat: log a warning instead of throwing an error for server host mismatch error

chore: cleanup and docs fixes

a3c37b3

Merge pull request #7272 from QwikDev/v2-cleanup-fixes

89947db

chore: cleanup and docs fixes

V2 Version Packages (alpha) (#7244)

d848ba5

Version Packages (alpha) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

@@ -895,3 +895,3 @@
                     } else if (key === dangerouslySetInnerHTML) {
-                      (element as any).innerHTML = value!;
+                      (element as any).innerHTML = escapeHTML(String(value));
                     } else {

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: v2 release #6903

refactor: v2 release #6903

wmertens commented Sep 22, 2024 •

edited

Loading

changeset-bot bot commented Sep 22, 2024 •

edited

Loading

pkg-pr-new bot commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

refactor: v2 release #6903

Are you sure you want to change the base?

refactor: v2 release #6903

Conversation

wmertens commented Sep 22, 2024 • edited Loading

changeset-bot bot commented Sep 22, 2024 • edited Loading

🦋 Changeset detected

pkg-pr-new bot commented Sep 23, 2024 • edited Loading

github-actions bot commented Sep 23, 2024 • edited Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

wmertens commented Sep 22, 2024 •

edited

Loading

changeset-bot bot commented Sep 22, 2024 •

edited

Loading

pkg-pr-new bot commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading