This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
do not apply deletion of addresses to DB, only to output #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a debugging feature that was not even used in the main binary and which was not even valid since addresses to delete are computed on the fly.
remi-dupre
force-pushed
the
virual-deletion
branch
from
fb657f5
to
0da81b7
Compare
sdrll
approved these changes
Mar 9, 2022
| /// A database, this structure can be used to open connections or perform high-level operations. | ||
| pub struct DbHashes { | ||
| db_path: PathBuf, | ||
| to_delete: HashSet<i64>, |
There was a problem hiding this comment.
IMO it could be difficult to understand that the hashset is outside the sqlite DB, because sometimes it could be weird to manipulate the Hashset from the DbHashes instance. I don't have a lot of idea apart from renaming the struct such as HashesStorages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior is the following:
These last two steps seem to take about half a day in our integration environment while they perform some overly complicated tasks.
This PR removes these last two steps and just reuses the
HashSetcomputed at step 1 to filter addresses (with no I/O) while we output them for the final dump.