fix: a hidden problem that can lead to goroutine leaks

Qv2ray · May 9, 2021 · addefca · addefca
1 parent 04bf6df
commit addefca
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/dispatcher/udp/udp.go b/dispatcher/udp/udp.go
@@ -127,6 +127,16 @@ func (d *UDP) GetOrBuildUCPConn(laddr net.Addr, data []byte) (rc *net.UDPConn, e
 		// auth every server
 		server, content := d.Auth(buf, data, userContext)
 		if server == nil {
+			d.nm.Lock()
+			// remove socketIdent to avoid goroutine leak
+			if conn, ok = d.nm.Get(socketIdent); ok {
+				select {
+				case <-conn.Establishing:
+				default:
+					d.nm.Remove(socketIdent)
+				}
+			}
+			d.nm.Unlock()
 			return nil, AuthFailedErr
 		}