chore: do not warn on ignored denom

[freak12techno]

Summary by CodeRabbit

• Bug Fixes

  • Improved the warning display logic to ensure warnings are only shown if CoingeckoCurrency is empty and Ignore is false.

• Tests

  • Added new tests to validate the behavior of DenomInfo warnings and ignore conditions.

[coderabbitai]

Walkthrough

The recent changes improve the DenomInfo struct in the DisplayWarnings method by adding a condition to check if CoingeckoCurrency is empty and Ignore is false before appending a warning message. New test functions were also introduced to ensure the correct behavior of these modifications, enhancing the validation and warning display mechanisms for DenomInfo.

Changes

Files	Summary
pkg/config/denom_info.go	Added a condition to check if CoingeckoCurrency is empty and Ignore is false in the DisplayWarnings method.
pkg/config/denom_info_test.go	Added TestDenomInfoValidateNoDisplayDenomIgnored and TestDenomInfoDisplayWarningNoCoingeckoDisabled to test new scenarios.

Poem

A Denom’s tale, with warnings keen,
Where checks for Coingecko now are seen,
If currency is nil and ignore not set,
A warning message you will get.
Amidst the tests, validations fly,
Ensuring code does rightly comply.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1f51763) to head (18be41a).

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         2585      2585           
=========================================
  Hits          2585      2585           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1f51763 and 18be41a.

Files selected for processing (2)

• pkg/config/denom_info.go (1 hunks)
• pkg/config/denom_info_test.go (3 hunks)

Additional context used

Learnings (1)

pkg/config/denom_info_test.go (1)

Learnt from: freak12techno
PR: QuokkaStake/cosmos-validators-exporter#64
File: pkg/config/consumer_chain_test.go:63-63
Timestamp: 2024-06-25T21:31:42.607Z
Learning: In `pkg/config/consumer_chain_test.go`, incomplete `DenomInfos` fields are intentionally set to trigger validation failures as part of testing error handling.

Additional comments not posted (3)

pkg/config/denom_info.go (1)

33-33: LGTM! The additional condition is logical.

The added check for Ignore being false ensures that warnings are only displayed when Ignore is false, which aligns with the intended behavior.

pkg/config/denom_info_test.go (2)

29-35: LGTM! The test correctly validates the Ignore field behavior.

The test function appropriately checks that no error is returned when Ignore is true and DisplayDenom is empty.

---

53-59: LGTM! The test correctly validates the Ignore field behavior.

The test function appropriately checks that no warnings are returned when Ignore is true and CoingeckoCurrency is empty.