-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add active validators gauge for consumers #68
Conversation
WalkthroughThe overall change introduces a new Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 90.54% 90.71% +0.16%
==========================================
Files 60 61 +1
Lines 2402 2455 +53
==========================================
+ Hits 2175 2227 +52
- Misses 226 227 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- pkg/app.go (1 hunks)
- pkg/fetchers/consumer_info.go (1 hunks)
- pkg/fetchers/consumer_validators.go (1 hunks)
- pkg/fetchers/has_to_validate.go (1 hunks)
- pkg/fetchers/signing_info.go (1 hunks)
- pkg/generators/single_validator_info.go (3 hunks)
- pkg/generators/single_validator_info_test.go (3 hunks)
- pkg/generators/validator_active.go (1 hunks)
- pkg/generators/validator_active_test.go (1 hunks)
Files not reviewed due to errors (2)
- pkg/generators/single_validator_info_test.go (no review received)
- pkg/generators/validator_active_test.go (no review received)
Files skipped from review due to trivial changes (3)
- pkg/fetchers/consumer_info.go
- pkg/fetchers/consumer_validators.go
- pkg/generators/single_validator_info.go
Additional context used
GitHub Check: codecov/patch
pkg/app.go
[warning] 122-122: pkg/app.go#L122
Added line #L122 was not covered by tests
Additional comments not posted (3)
pkg/fetchers/has_to_validate.go (1)
39-39
: Logger component name updated for clarity.The change from a generic or incorrect logger name to
validator_consumers_fetcher
improves the clarity and traceability of log messages, which is especially useful for debugging and monitoring.pkg/generators/validator_active.go (1)
27-27
: Logger component name set appropriately in the constructor.Setting the logger component name to
validator_active_generator
helps in identifying logs specific to this generator, which is crucial for debugging and maintenance.pkg/fetchers/signing_info.go (1)
40-40
: Logger component name updated for better specificity.Updating the logger component name to
signing_infos_fetcher
enhances the specificity and traceability of log messages, aiding in debugging and operational monitoring.
Summary by CodeRabbit
New Features
ValidatorActiveGenerator
to generate Prometheus metrics for active validators.Bug Fixes
ConsumerInfoFetcher
,ConsumerValidatorsFetcher
,ValidatorConsumersFetcher
,SigningInfoFetcher
).Improvements
isActiveGauge
metric fromSingleValidatorInfoGenerator
.isActiveGauge
metric.