fix: fixed checking responses (#51)

QuokkaStake · May 14, 2024 · 79de805 · 79de805
1 parent 47d1fc8
commit 79de805
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/pkg/fetchers/staking_params.go b/pkg/fetchers/staking_params.go
@@ -68,7 +68,7 @@ func (q *StakingParamsFetcher) Fetch(
 				q.Logger.Error().
 					Err(err).
 					Str("chain", chain.Name).
-					Msg("Error querying slashing params")
+					Msg("Error querying staking params")
 				return
 			}
 

diff --git a/pkg/fetchers/validators.go b/pkg/fetchers/validators.go
@@ -30,7 +30,7 @@ func NewValidatorsFetcher(
 	tracer trace.Tracer,
 ) *ValidatorsFetcher {
 	return &ValidatorsFetcher{
-		Logger: logger.With().Str("component", "commission_fetcher").Logger(),
+		Logger: logger.With().Str("component", "validators_fetcher").Logger(),
 		Config: config,
 		RPCs:   rpcs,
 		Tracer: tracer,

diff --git a/pkg/tendermint/tendermint.go b/pkg/tendermint/tendermint.go
@@ -213,6 +213,11 @@ func (rpc *RPC) GetValidatorCommission(
 		return []types.Amount{}, &info, err
 	}
 
+	if response.Code != 0 {
+		info.Success = false
+		return []types.Amount{}, &info, fmt.Errorf("expected code 0, but got %d", response.Code)
+	}
+
 	return utils.Map(response.Commission.Commission, func(amount types.ResponseAmount) types.Amount {
 		return amount.ToAmount()
 	}), &info, nil
@@ -286,6 +291,11 @@ func (rpc *RPC) GetWalletBalance(
 		return []types.Amount{}, &info, err
 	}
 
+	if response.Code != 0 {
+		info.Success = false
+		return nil, &info, fmt.Errorf("expected code 0, but got %d", response.Code)
+	}
+
 	return utils.Map(response.Balances, func(amount types.ResponseAmount) types.Amount {
 		return amount.ToAmount()
 	}), &info, nil
@@ -343,6 +353,11 @@ func (rpc *RPC) GetSlashingParams(
 		return nil, &info, err
 	}
 
+	if response.Code != 0 {
+		info.Success = false
+		return nil, &info, fmt.Errorf("expected code 0, but got %d", response.Code)
+	}
+
 	return response, &info, nil
 }
 

diff --git a/pkg/types/tendermint.go b/pkg/types/tendermint.go
@@ -92,6 +92,7 @@ type ValidatorsResponse struct {
 }
 
 type BalancesResponse struct {
+	Code     int              `json:"code"`
 	Balances []ResponseAmount `json:"balances"`
 }
 
@@ -120,6 +121,7 @@ type SigningInfoResponse struct {
 }
 
 type SlashingParamsResponse struct {
+	Code           int `json:"code"`
 	SlashingParams struct {
 		SignedBlocksWindow string `json:"signed_blocks_window"`
 	} `json:"params"`