Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set image source after setting decode size to fix #71 #77

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dreamlayers
Copy link
Contributor

Images were decoding at full size despite setting decode size.
This seems to be because the source was set first, so the image
could decode before decode size was set.

It seems the intent was to initially display images scaled to fit, but images were decoding at full size because the source was set before the decode sizes. In Microsoft's example, the source is set after, and setting the source after fixes the problem. There may have been a race condition here, because images were sometimes displayed scaled to fit initially.

With this change the behaviour is:

Images always load scaled to fit initially. Control + mouse wheel up goes to a 1:1 view where I can zoom in and out smoothly via Control + mouse wheel. If I zoom out until the image fits, it goes back to the initial state.

Images were decoding at full size despite setting decode size.
This seems to be because the source was set first, so the image
could decode before decode size was set.
@get-fooby
Copy link

Has this made it into the store release? there is still chatter about this on the baconit subreddit...

@farid-fari
Copy link

1 year later, it'd be cool if this were implemented...

I think I'll have to selfbuild and sideload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants