forked from FabricMC/fabric
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to FAPI 0.91.0+1.20.1
#140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes FabricBlockSettings' copyOf method missing several new settings introduced as a result of the removal of Materials. Specifically, burnable, liquid, forceNotSolid, forceSolid, pistonBehavior, instrument, and replaceable. These are all copied by the vanilla `BlockSettings.copy` as well. The emissiveLightingPredicate is also now copied in vanilla, so I moved the copy of that to reflect that change. (cherry picked from commit 2ff98d3)
* Fix double gamerules rules not being editable in menu * Updated `validate`'s javadoc (cherry picked from commit a44e16a)
…teration (FabricMC#3423) (cherry picked from commit aaf9c96) (cherry picked from commit 9ab11d5)
I can squash some of the commits if need be. |
ix0rai
approved these changes
Dec 30, 2023
we don't squash commits on QFAPI, don't worry about it |
What is the status on this PR? does it need to sync QSL? |
Edit: Oh i see. no QSL sync needed. How is the rest of the PR? |
OroArmor
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This PR updates QFAPI to match FAPI
0.91.0+1.20.1
.Associated
QuiltBlockSettings
copy constructor does not copyburnable
flag quilt-standard-libraries#357