Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuiltBlockSettings copy constructor does not copy burnable flag #357

Closed
Kneelawk opened this issue Dec 10, 2023 · 2 comments
Closed

QuiltBlockSettings copy constructor does not copy burnable flag #357

Kneelawk opened this issue Dec 10, 2023 · 2 comments

Comments

@Kneelawk
Copy link

The Issue

While looking over FabricMC/fabric#3373 I noticed that QSL's implementation was missing copying the burnable flag. This appears to be the only thing QSL is missing from the referenced PR.
@Kneelawk Kneelawk mentioned this issue Dec 10, 2023
Merged
@Kneelawk
Copy link
Author

I'm investigating this more now, and I can't seem to find burnable in the AbstractBlock.Settings class, even though it is referenced in an FAPI mixin.

@Kneelawk
Copy link
Author

Ok, turns out burnable is called lavaIgnitable in QM and I didn't notice FAPI didn't have it the first time over. So QSL does actually copy the burnable flag, just under another name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kneelawk