Apply suggestions from code review

Co-authored-by: Will <[email protected]>

build.gradle

@@ -190,7 +190,7 @@ task mappingsUnpickedServer(type: EnigmaMappingsServerTask, dependsOn: unpickHas
 }
 
 task mappingsServer(type: EnigmaMappingsServerTask, dependsOn: "mapPerVersionMappingsJar") {
-	jarToMap.set mappings.fileConstants.perVersionMappingsJar
+	jarToMap.set project.extensions.mappings.fileConstants.perVersionMappingsJar
 }
 
 // Only build jars for package infos if we need to actually expose stuff like annotation in the future.

buildSrc/src/main/java/quilt/internal/tasks/mappings/EnigmaMappingsServerTask.java

@@ -1,7 +1,9 @@
 package quilt.internal.tasks.mappings;
 
 import org.gradle.api.Project;
+import org.gradle.api.file.DirectoryProperty;
 import org.gradle.api.file.RegularFileProperty;
+import org.gradle.api.tasks.InputDirectory;
 import org.gradle.api.tasks.InputFile;
 import org.gradle.api.tasks.JavaExec;
 import quilt.internal.Constants;
@@ -10,24 +12,24 @@
 import java.util.ArrayList;
 import java.util.List;
 
-public class EnigmaMappingsServerTask extends JavaExec implements MappingsTask {
+public abstract class EnigmaMappingsServerTask extends JavaExec implements MappingsTask {
 	@InputFile
 	private final RegularFileProperty jarToMap;
-	@InputFile
-	private final RegularFileProperty mappings;
+	@InputDirectory
+	protected abstract DirectoryProperty getMappings();
 
 	private final List<String> serverArgs;
 
 	public EnigmaMappingsServerTask() {
-		Project project = this.getProject();
+		final Project project = this.getProject();
 		this.setGroup(Constants.Groups.MAPPINGS_GROUP);
 		this.getMainClass().set("org.quiltmc.enigma.network.DedicatedEnigmaServer");
 		this.classpath(project.getConfigurations().getByName("enigmaRuntime"));
 		this.jvmArgs("-Xmx2048m");
 
 		this.jarToMap = getObjectFactory().fileProperty();
 		this.mappings = getObjectFactory().fileProperty();
-		this.mappings.convention(() -> this.getProject().file("mappings"));
+		this.getMappings().convention(project.getLayout().dir(project.provider(() -> project.file("mappings"))));
 
 		this.serverArgs = new ArrayList<>();
 
@@ -55,7 +57,7 @@ public EnigmaMappingsServerTask() {
 	public void exec() {
 		var args = new ArrayList<>(List.of(
 				"-jar", this.jarToMap.get().getAsFile().getAbsolutePath(),
-				"-mappings", this.mappings.get().getAsFile().getAbsolutePath(),
+				"-mappings", this.getMappings().get().getAsFile().getAbsolutePath(),
 				"-profile", "enigma_profile.json"
 		));
 		args.addAll(this.serverArgs);