Use proper publishing methods. Fix #82. Pin loom. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyrofab
reviewed
Dec 30, 2023
Comment on lines
+195
to
199
| // Publish Sources Jar | ||
| artifact(tasks.remapSourcesJar.get().archiveFile) { | ||
| builtBy(tasks.remapSourcesJar) | ||
| this.classifier = "sources" | ||
| } |
There was a problem hiding this comment.
Are sources not part of the kotlin component ?
There was a problem hiding this comment.
no, thats usually done by loom (i.e java { withSourcesJar() })
since the dokka artifact already needs to be attached, it makes more sense imo to just leave it here as part of the whole publication
Pyrofab
approved these changes
Dec 30, 2023
|
As far as I can tell this looks good to me, results in publishing a gradle module file as well as dependencies in the POM file. Ignore the version numbers, they are from some local testing to compare changes of maven artefacts: |
ghost
approved these changes
Feb 8, 2024
ghost
mentioned this pull request
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.