Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait frame processing on sync end #412

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Wait frame processing on sync end #412

merged 1 commit into from
Jan 9, 2025

Conversation

petricadaipegsp
Copy link
Contributor

References #411

This is an alternative to #411 with the following two advantages:

  • It respect context cancellations, so it won't delay the closure of the main process.
  • It awaits the actual frames which have been inserted by the sync process, so even if the processing fails, it can still progress.

@petricadaipegsp petricadaipegsp marked this pull request as ready for review December 12, 2024 22:56
@CassOnMars CassOnMars changed the base branch from develop to v2.0.6 January 9, 2025 08:32
@CassOnMars CassOnMars merged commit 0b831de into QuilibriumNetwork:v2.0.6 Jan 9, 2025
@petricadaipegsp petricadaipegsp deleted the fix/await-sync-end branch January 9, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petricadaipegsp @CassOnMars