Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP/HTTPS protocol for ClickHouse connection #938

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Oct 31, 2024

  1. Make ClickHouse connection configuration more user-friendly

    Before this change, Quesma supported only the "clickhouse://" protocol
    to connect to ClickHouse. However, ClickHouse also supports the HTTP
    protocol (8123) and HTTPS protocol (8443). This PR extends the
    ClickHouse connection logic to switch to using HTTP(S) protocol if the
    user put that endpoint instead.
    
    This change is motivated by the fact that the HTTPS endpoint is the
    first/default endpoint shown on ClickHouse Cloud and by the fact that
    we saw a user try to use the HTTP endpoint.
    avelanarius committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    2548a84 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    17ef2cd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba73ad3 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Configuration menu
    Copy the full SHA
    15f5245 View commit details
    Browse the repository at this point in the history
  2. static check fix

    avelanarius committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0bf2e28 View commit details
    Browse the repository at this point in the history