Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage report for clickhouse #1039

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Usage report for clickhouse #1039

wants to merge 5 commits into from

Conversation

mieciu
Copy link
Member

@mieciu mieciu commented Nov 25, 2024 •
edited
Loading 

Nov 26 10:34:49.438 INF telemetry/phone_home.go:407 > 
Usage report dababase=[<no-user>@https://localhost:9000/default] table sizes=map[QUESMA_all_tables_in_bytes:6821641 opensearch_dashboards_sample_data_ecommerce:4077877 opensearch_dashboards_sample_data_flights:2743764]

@mieciu mieciu marked this pull request as ready for review November 26, 2024 15:58
@mieciu mieciu requested a review from a team as a code owner November 26, 2024 15:58
nablaone
nablaone reviewed Nov 27, 2024
View reviewed changes
quesma/telemetry/phone_home.go
@@ -539,6 +596,11 @@ func (a *agent) collect(ctx context.Context, reportType string) (stats PhoneHome
} else {
stats.ClickHouse = ClickHouseStats{Status: "paused"}
}
if !strings.HasPrefix(a.config.ClickHouse.ConnectorType, "hydrolix") { // we only check table sizes for ClickHouse
if tables, err := a.collectClickHouseTableSizes(ctx); err == nil {
logger.Info().Msgf("Usage report dababase=[%s] table sizes=%v", a.getDbInfo(), tables)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this logged only? We can add this site to the clickhouse stats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nablaone nablaone nablaone left review comments

@jakozaur jakozaur Awaiting requested review from jakozaur jakozaur is a code owner automatically assigned from QuesmaOrg/engineering

@trzysiek trzysiek Awaiting requested review from trzysiek trzysiek is a code owner automatically assigned from QuesmaOrg/engineering

@avelanarius avelanarius Awaiting requested review from avelanarius avelanarius is a code owner automatically assigned from QuesmaOrg/engineering

@pdelewski pdelewski Awaiting requested review from pdelewski pdelewski is a code owner automatically assigned from QuesmaOrg/engineering

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mieciu @nablaone