Retire old qubes-vm-create dialog
#393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Development notes: Adding |
alimirjamali
force-pushed
the
issue-6561-qubes-vm-create
branch
2 times, most recently
from
be68559
to
14cc82d
Compare
|
As noted in the other issue, IMO better to simply remove the old create qube dialog (and replace its use with the new one). |
|
I'll pick just the dependency fix from here |
OK. But I think it is better to do it for 4.3 branch and not 4.2. I will make a separate PR for the above task, properly ditching the old one. So it could be easily merged to 4.3 branch. |
|
Well, "main" branch is "4.3 branch" :) |
alimirjamali
force-pushed
the
issue-6561-qubes-vm-create
branch
from
14cc82d
to
c79cbf5
Compare
alimirjamali
changed the title
Create Qubes VM to the xfce4-panel menuqubes-vm-create dialog
marmarta
suggested changes
Nov 25, 2024
alimirjamali
force-pushed
the
issue-6561-qubes-vm-create
branch
from
c79cbf5
to
e4f6046
Compare
Retire the the old PyQt based `qubes-vm-create` dialog and replace it with GTK based `qubes-new-qube` for Qube Manager. resolves: QubesOS/qubes-issues#6561
alimirjamali
force-pushed
the
issue-6561-qubes-vm-create
branch
from
e4f6046
to
210f867
Compare
10 tasks
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024112705-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update
Failed tests9 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/119126#dependencies 2 fixed
Unstable tests
|
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: QubesOS/qubes-issues#6561