Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass all focus events to clients #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pass all focus events to clients #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions gui-daemon/xside.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1941,15 +1941,25 @@ static void process_xevent_focus(Ghandles * g, const XFocusChangeEvent * ev)
struct msg_focus k;
CHECK_NONMANAGED_WINDOW(g, ev->window);

/* Ignore everything other than normal, non-temporary focus change. In
* practice it ignores NotifyGrab and NotifyUngrab. VM does not have any
* way to grab focus in dom0, so it shouldn't care about those events. Grab
* is used by window managers during task switching (either classic task
* switcher, or KDE "present windows" feature).
/* In the past, the GUI daemon ignored several such events. The
* comment used to say:
*
* > Ignore everything other than normal, non-temporary focus change. In
* > practice it ignores NotifyGrab and NotifyUngrab. VM does not have any
* > way to grab focus in dom0, so it shouldn't care about those events. Grab
* > is used by window managers during task switching (either classic task
* > switcher, or KDE "present windows" feature).
*
* In particular, events with modes other than NotifyNormal and
* NotifyWhileGrabbed were ignored.
*
* This caused problems, though. It turns out that some
* applications actually do care about these events, and ignoring
* them causes things to break. In particular, this resulted in
* lost keymap updates and the agent and daemon no longer agreeing
* on which keys are pressed. Therefore, the GUI daemon now sends
* such events to clients, and does not clobber the mode value.
*/
if (ev->mode != NotifyNormal && ev->mode != NotifyWhileGrabbed)
return;

if (ev->type == FocusIn) {
char keys[32];
XQueryKeymap(g->display, keys);
Expand All @@ -1960,10 +1970,7 @@ static void process_xevent_focus(Ghandles * g, const XFocusChangeEvent * ev)
hdr.type = MSG_FOCUS;
hdr.window = vm_window->remote_winid;
k.type = ev->type;
/* override NotifyWhileGrabbed with NotifyNormal b/c VM shouldn't care
* about window manager details during focus switching
*/
k.mode = NotifyNormal;
k.mode = ev->mode;
k.detail = ev->detail;
write_message(g->vchan, hdr, k);
}
Expand Down