Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce LocalVM to extract BaseVM being smaller class #637

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fepitre
Copy link
Member

@fepitre fepitre commented Nov 23, 2024

It prepares the work for RemoteVM.

@fepitre
Copy link
Member Author

fepitre commented Nov 23, 2024

@marmarek can you run openQA on it please?

@marmarek
Copy link
Member

Sure, I can, but I think you may want to first take care of unit tests, this one looks like a real issue:

  File "/home/user/builds/QubesOS/qubes-core-admin/qubes/vm/__init__.py", line 403, in load_extras
    for parent in self.xml.xpath("./devices"):
                  ^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'xpath'

@fepitre fepitre force-pushed the localvm branch 2 times, most recently from c134529 to 0e2e8d9 Compare November 23, 2024 13:54
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.53%. Comparing base (039b7d3) to head (e308e84).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
+ Coverage   69.49%   69.53%   +0.03%     
==========================================
  Files          58       58              
  Lines       12465    12478      +13     
==========================================
+ Hits         8663     8676      +13     
  Misses       3802     3802              
Flag Coverage Δ
unittests 69.53% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@fepitre
Copy link
Member Author

fepitre commented Nov 25, 2024

Sure, I can, but I think you may want to first take care of unit tests, this one looks like a real issue:

  File "/home/user/builds/QubesOS/qubes-core-admin/qubes/vm/__init__.py", line 403, in load_extras
    for parent in self.xml.xpath("./devices"):
                  ^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'xpath'

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants