Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background fit bugfix, typecast fix, GwyImage data setter fix #18

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

ngergihun
Copy link
Contributor

No description provided.

@markotoplak markotoplak merged commit 8f87074 into Quasars:master Sep 24, 2024
6 checks passed
@markotoplak
Copy link
Contributor

I merged, but implicit cast to integers within __init__ is not nice. Instead, it should crash (=raise an exception) if it is not integer.

I like that libraries do not do anything unexpected and that they complain loudly whenever something is unusual. Oh the other hand, GUI applications should just do as many necessary adaption as needed to get some output BUT they should still somehow warn you that something strange was done.

@ngergihun
Copy link
Contributor Author

Thanks Marko for the suggestions. What is the standard way to make the methods more compatible with GUI usage? Just returning some default values and raising an error in case of calculation goes wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants