[ENH] SoftiMax HDF5 reader #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuart-cls
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Looks good! I like this approach, better to get it in and combine later. Example file / tests would be good.
I would guess these are actually NXstxm files and we can use that logic in the future.
Also, I will change the order of x_locs and y_locs in the HERMES reader because the current code will crash with non-square maps.
I don't understand this comment.
|
I'll merge this for now so that it is released, but tests would be appreciated. |
|
Thanks guys! I will write tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a change for the HERMES reader to ensure that the file is closed after reading and a new HDF5 reader for the Max-IV SoftiMax beamline that has almost the same entries as the HERMES (counter instead of Counter). Instead of doing some string manipulation magic I added a new class. Eventually it would be nice to unify these readers though.
Also, I will change the order of
x_locsandy_locsin the HERMES reader because the current code will crash with non-square maps.To come: small SoftiMax test file and reader test.