Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] HyperSpectra: move image properties to control area #777

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

markotoplak
Copy link
Collaborator

HyperSpectra has too many options in the menu, and some of them are as important as the ones in the control area. I suggest to unify this.

image

I have been thinking about this for a while, especially when doing workshops and students do not understand, why do their images look so funny, when they only had strangely set axes. MY final motivation was #765, which adds additional options. Having less often used options in control panel and more common ones (especially axes) in the menu seemed off to me. Therefore, I tried this and to me it seems fine.

Asking for comments, especially @stuart-cls and @borondics.

In #765 I also made visual image pane smaller if disabled.

@borondics
Copy link
Member

borondics commented Nov 26, 2024

Hi @markotoplak, I think you are right about this, the feature is too hidden in the menu, so this change is quite timely. If we go with this though I think we should be starting to enable collapsing those boxes because soon we will need to scroll the left panel, especially with smaller windows (like the example) or monitors.

In the long term I would really like to have it working by interacting with the colorbar itself, not from a menu or panel.
Here is an example of a pyqtgraph colorbar where the user can set the lower/upper color limits using those lines in the CB:
image

As I see now we have our own colorbar implementation - is this a must or we can default to pyqtgraph here?

I guess in any case adding double click and right click functionalities would not be too hard, although one could argue that these are also hidden features, but I think they would be also intuitive.

@markotoplak
Copy link
Collaborator Author

I am open to nicer color choices in the future. The limit sliders are exactly what are you showing here are could be replaceable.

But do we go forward with this for now?

@borondics
Copy link
Member

borondics commented Nov 26, 2024 via email

@markotoplak
Copy link
Collaborator Author

It is probably easy to add, but I would not (no other widgets use something similar).

For now, we'll collapse open vector plots and visual images because they are rarely used.

If the UI is too cluttered, we could hide inactive settings in Image Values.

@stuart-cls
Copy link
Member

💯 💯 💯 from me.

The hidden axis thing has bitten so many users (and also me). It also matches other widgets like scatterplot etc better.

Thanks @markotoplak !

@stuart-cls
Copy link
Member

Ah, the "Image colors" box should probably disappear on RGB mode. It looks strange just empty:

image

@stuart-cls
Copy link
Member

Should we do this to Spectral Series as well? I think it's the only other widget with this type of view (at least, in this repo).

@markotoplak
Copy link
Collaborator Author

OK, I'll merge this for now and then let's add fixes to it to make it better. I would also make RGB image values selector disappear unless that mode was selected.

@markotoplak markotoplak merged commit 05c00ee into Quasars:master Nov 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants