-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perkin Elmer file reader #774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
You need to add the test files to MANIFEST.in
before we can find out if the tests pass :)
Generally, I don't love the structure of the reader:
- It's two readers jammed into one for no reason I can see.
- I don't really like the API boundary between the
specio
code and the reader code. Looking atspecio
, I can see why it was done this way. I would prefer to keep the code-copies in theutils
folder and the Orange-specific stuff only in the reader section.
I understand if you don't have much appetite for pedantic refactoring :) I don't think it will affect maintainability so skip it if you'd rather not.
Thanks for the comments guys, I tried to improve things! Have a look... |
Before merging, this should be rebased into a single commit. Also, there is a file with CRLF (main lint's complain). This should be reformatted. I can do this steps, when ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good from my side, don't forget @markotoplak comment about line endings and squashing the commits.
Then, it is good for me too... @markotoplak, would you merge it? |
64470e2
to
1e44aa9
Compare
Tests are bad. Test should not skip complex parts of the code, like image coordinates, which are not tested at all. This should be improved. |
I am merging this as is, but tests should really be made better. |
[ENH] Perkin Elmer file reader
Thanks for merging! I added map coordinate tests in #776 |
Based on existing code from specio and from colleagues at the Diamond synchrotron comes a new reader for Perkin Elmer files.