[ENH] Speedup 2D COS widget #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an example how to parallelize isocurves, but we figured out that the slow part is actually the plotting, so I am removing this. |
markotoplak
reviewed
Nov 14, 2024
markotoplak
reviewed
Nov 14, 2024
markotoplak
reviewed
Nov 20, 2024
markotoplak
changed the title
markotoplak
reviewed
Nov 20, 2024
| @@ -15,7 +15,7 @@ | |||
| from orangewidget.utils.visual_settings_dlg import VisualSettingsDialog | |||
| from orangecontrib.spectroscopy.data import getx | |||
| from orangecontrib.spectroscopy.widgets.owhyper import ImageColorLegend | |||
| from orangecontrib.spectroscopy.widgets.owspectra import InteractiveViewBox | |||
There was a problem hiding this comment.
Remove this unneeded import (found it in the lint)
|
I simplify the code a bit and intend to merge if tests pass. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
50x speedup in computation and significant (> 10x) speedup in plotting