NeaReaderMultiChannel - Apply wavenumber scaling to Δx #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailable Checks metadata on wavenumber scaling factor and and apply it to Δx to be used by the fft.
|
This does not seem as if could break anything, so I am OK (even though I have no idea what it does :) ). Thanks! |
markotoplak
changed the title
|
It works on my mac and I could also build a workflow to convert the IFGs into a spectrum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes on the multichannel interferogram reader (NeaReaderMultiChannel) so it can check for wavenumber scaling factor metadata and apply it as a corresponding scaling factor to Δx (used by the fft).
I think @raul-freitas can explain better how this is factor comes from the device generating the data, but in short it is calculated comparing the experimental data to reference values (i.e. water vapor lines) during the data collection.
We discussed how to implement this in #717 and now @raul-freitas validated the necessity of using this factor in the Δx calculated from the positional reference (M) we are using for this type of file.