Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nea .gsf files not always include Interferometer Center/Distance #758

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

markotoplak
Copy link
Collaborator

@markotoplak markotoplak commented Oct 4, 2024

#739 broke the existing Nea gsf reader. At least some of the files I see lack "Interferometer Center/Distance" and therefore it crashes.

@markotoplak
Copy link
Collaborator Author

@brnovasco, I see you added the part that was crashing from @borondics's file.

Why did you expect that this always appears in the files? It is in the specification? Or is it version dependant?

@markotoplak markotoplak merged commit 612d90c into Quasars:master Oct 4, 2024
10 of 14 checks passed
@ngergihun
Copy link
Contributor

@markotoplak I think we have run into a image gsf against spectrum gsf issue. The old neaspec gsf reader was meant to import interferograms or spectra because way back in time neaspec was exporting these measurements also in .gsf. At the same time, neaspec also exports single image data as .gsf but the image files (like the one from @borondics) have no "Interferometer Center/Distance" header lines.

@markotoplak
Copy link
Collaborator Author

Ok, I understand that this can happen, but we have to ensure that the common utilities run for all the variants.

@brnovasco
Copy link
Contributor

@brnovasco, I see you added the part that was crashing from @borondics's file.

Why did you expect that this always appears in the files? It is in the specification? Or is it version dependant?

I was replicating the behavior that was written in the owfft widget, that assumes that if the reader is 'NeaReaderGSF' it expects it to have the 'Interferometer Center/Distance' field. Sorry I missed this error.

@markotoplak
Copy link
Collaborator Author

Oh, I understand. Thanks for the explanation. No problem, we'll have to remodel these readers anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants