[MNT] Refactor preprocess tests #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because tile reading uses domain transformations that are already tested in TestConversionIndpSamplesMixin
|
So this helped me find a bug in the other repo even though I honestly though that nothing can be wrong there... Tests are useful. |
|
This PR should not break anything (it is only tests). I'll review the code again and then merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing common preprocessor functionality - also lovingly called torture tests - relied on putting preprocessors into a special list in
test_preprocess.py. This prevented reusing tests in other repositories.An example of a PR that could benefit them: Quasars/orange-snom/pull/4
This PR refactors preprocessor tests so that torture tests can now be mixed into the test class.