[FIX] Disable __eq__ and __hash__ because it can be slow #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be so slow that it appears Orange has crashed.
|
I intend to merge this and re-release. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #713 +/- ##
==========================================
- Coverage 88.53% 88.15% -0.39%
==========================================
Files 73 73
Lines 12613 12613
==========================================
- Hits 11167 11119 -48
- Misses 1446 1494 +48 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be so slow that it appears Orange has crashed.
With @borondics we had a workshop in Berlin and preprocessing appeared to crash for most students. We thus downgraded to a previous version.
After debugging I saw that a series of preprocessors causes domain comparisons to be very long (for example, after normalization, each feature in turn references the whole original domain, and then equality checking just multiplies).