Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] agilent-format package, support incomplete datasets #712

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

stuart-cls
Copy link
Member

Update to v0.4.5 which primarily exists to support incomplete datasets: when an expected tile is loaded and the tile doesn't exist, returns an appropriately sized array of NaNs.

In the case of tile-loader, these NaNs are then filtered out (since the Table structure is more forgiving of gaps than a numpy array)

I also took this opportunity to finish publishing as a package: https://pypi.org/project/agilent-format

Full changes from 0.4.4 to 0.4.5: stuart-cls/python-agilent-file-formats@0.4.4...0.4.5

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Merging #712 (c2ee161) into master (ff7c581) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
- Coverage   88.53%   88.51%   -0.03%     
==========================================
  Files          73       72       -1     
  Lines       12613    12285     -328     
==========================================
- Hits        11167    10874     -293     
+ Misses       1446     1411      -35     

@markotoplak markotoplak changed the title io: agilent-format package, support incomplete datasets [ENH] agilent-format package, support incomplete datasets Mar 26, 2024
@markotoplak markotoplak merged commit df311e2 into Quasars:master Mar 26, 2024
13 of 16 checks passed
@stuart-cls stuart-cls deleted the agilent-format-package branch April 9, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants