Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSC: __eq__ and __hash__ #697

Merged
merged 5 commits into from
Nov 17, 2023
Merged

EMSC: __eq__ and __hash__ #697

merged 5 commits into from
Nov 17, 2023

Conversation

markotoplak
Copy link
Collaborator

@markotoplak markotoplak commented Nov 16, 2023

Fixes #662

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #697 (baf3156) into master (1cbe659) will decrease coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head baf3156 differs from pull request most recent head 0636def. Consider uploading reports for the commit 0636def to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
- Coverage   88.76%   88.75%   -0.01%     
==========================================
  Files          73       73              
  Lines       12546    12546              
==========================================
- Hits        11136    11135       -1     
- Misses       1410     1411       +1     

@markotoplak markotoplak marked this pull request as ready for review November 16, 2023 13:23
@markotoplak
Copy link
Collaborator Author

I am merging this so that it gets tested better. :)

@markotoplak markotoplak merged commit c048dd4 into Quasars:master Nov 17, 2023
5 of 14 checks passed
@markotoplak markotoplak deleted the new-eq branch July 10, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning with EMSC and __hash__
1 participant