-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
express, qsimplify, and latexify updates #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Feel free to merge after addressing the comments if tests pass.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 65.76% 66.25% +0.48%
==========================================
Files 15 15
Lines 628 646 +18
==========================================
+ Hits 413 428 +15
- Misses 215 218 +3 ☔ View full report in Codecov by Sentry. |
Permission to merge after tests pass and comments are addressed.
express
and added more tests intest_express_cliff.jl
.qsimplify
can now traverse through subexpressions usingPrewalk
fromSymbolicUtils.jl
. This required definingmaketerm
fromTermInterface.jl
for each symbolic operation.