Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

express, qsimplify, and latexify updates #57

Merged
merged 9 commits into from
Jun 29, 2024

Conversation

apkille
Copy link
Member

@apkille apkille commented Jun 28, 2024

  • Added a doc that describes features of express and added more tests in test_express_cliff.jl.
  • qsimplify can now traverse through subexpressions using Prewalk from SymbolicUtils.jl. This required defining maketerm from TermInterface.jl for each symbolic operation.
  • Added latexify capabilities and fixed bug mentioned in latexify partially broken after #40 #49 .

Copy link
Member

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Feel free to merge after addressing the comments if tests pass.

src/QSymbolicsBase/basic_ops_homogeneous.jl Outdated Show resolved Hide resolved
docs/src/express.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 66.25%. Comparing base (4df75a0) to head (6f7f5f4).
Report is 1 commits behind head on main.

Files Patch % Lines
src/QSymbolicsBase/latexify.jl 0.00% 17 Missing ⚠️
ext/QuantumCliffordExt/QuantumCliffordExt.jl 0.00% 2 Missing ⚠️
src/QSymbolicsBase/basic_ops_homogeneous.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   65.76%   66.25%   +0.48%     
==========================================
  Files          15       15              
  Lines         628      646      +18     
==========================================
+ Hits          413      428      +15     
- Misses        215      218       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apkille apkille requested a review from Krastanov June 28, 2024 15:45
@apkille apkille dismissed Krastanov’s stale review June 29, 2024 01:27

Permission to merge after tests pass and comments are addressed.

@apkille apkille merged commit 079ea5e into QuantumSavory:main Jun 29, 2024
15 of 17 checks passed
@apkille apkille deleted the express branch June 29, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants