-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
define BellSwap, NoisyBellSwap and T1NoiseOp #23
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 87.93% 88.59% +0.66%
==========================================
Files 2 2
Lines 232 307 +75
==========================================
+ Hits 204 272 +68
- Misses 28 35 +7 ☔ View full report in Codecov by Sentry. |
I made a few commits with changes. To continue working on this branch you need to pull these changes, either by the command |
Each commit has a descriptive message to it. You can click on it to see what changes were made. I generally try to separate commits in distinct single-purpose steps, so that it is easier to track why a change is being made. |
6c13434
to
babc0e6
Compare
babc0e6
to
f619fb9
Compare
…nd using a more standard naming convention
…to the use of np.exp which seems to have been copied from python's numpy -- as this code is not used or tested I just deleted it
merged! Thanks, @YipiaoWu , wonderful job! I added a bunch of minor additional changes -- please check out each commit to make sure we are on the same page about the changes. You can just do a pull in your main branch and these new capabilities should be available. I will shortly register a new public version as well. |
If you want to submit an unfinished piece of work in order to get comments and discuss, please mark the pull request as a draft and ping the repository maintainer.
Please address only one topic or issue per pull request! Many small PRs are much easier to review and merge than one large PR.
Before merging, all changes and new functionality should be marked in the CHANGELOG file, but feel free to just leave your CHANGELOG notes in the PR description, to avoid merge conflicts with other requests modifying that file. The maintainer will add these CHANGELOG notes for you if you do so.
Before considering your pull request ready for review and merging make sure that all of the following are completed (please keep the clecklist as part of your PR):
If possible, keep your git history not too wild (rebase and squash commits, keep commits small and semantically separated) so that review is easier.