Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define BellSwap, NoisyBellSwap and T1NoiseOp #23

Merged
merged 23 commits into from
Nov 5, 2024

Conversation

YipiaoWu
Copy link
Contributor

If you want to submit an unfinished piece of work in order to get comments and discuss, please mark the pull request as a draft and ping the repository maintainer.

Please address only one topic or issue per pull request! Many small PRs are much easier to review and merge than one large PR.

Before merging, all changes and new functionality should be marked in the CHANGELOG file, but feel free to just leave your CHANGELOG notes in the PR description, to avoid merge conflicts with other requests modifying that file. The maintainer will add these CHANGELOG notes for you if you do so.

Before considering your pull request ready for review and merging make sure that all of the following are completed (please keep the clecklist as part of your PR):

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.
  • We recently started enforcing formatting checks. If formatting issues are reported in the new code you have written, please correct them. There will be plenty of old code that is flagged as we are slowly transitioning to enforced formatting. Please do not worry about or address older formatting issues -- keep your PR just focused on your planned contribution.

If possible, keep your git history not too wild (rebase and squash commits, keep commits small and semantically separated) so that review is easier.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 86.41975% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.59%. Comparing base (cf6575d) to head (614270f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/BPGates.jl 86.41% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   87.93%   88.59%   +0.66%     
==========================================
  Files           2        2              
  Lines         232      307      +75     
==========================================
+ Hits          204      272      +68     
- Misses         28       35       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krastanov
Copy link
Member

I made a few commits with changes. To continue working on this branch you need to pull these changes, either by the command git pull or through the VS Code interface (there should be some kind of a "sync" button)

@Krastanov
Copy link
Member

Each commit has a descriptive message to it. You can click on it to see what changes were made. I generally try to separate commits in distinct single-purpose steps, so that it is easier to track why a change is being made.

@Krastanov Krastanov merged commit 4fdbb18 into QuantumSavory:main Nov 5, 2024
10 of 13 checks passed
@Krastanov
Copy link
Member

merged!

Thanks, @YipiaoWu , wonderful job! I added a bunch of minor additional changes -- please check out each commit to make sure we are on the same page about the changes.

You can just do a pull in your main branch and these new capabilities should be available. I will shortly register a new public version as well.

@Krastanov Krastanov mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants