Include git in Leiningen images #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to me. What do you think, @Quantisan? |
|
sounds good! |
alexander-yakushev
added a commit
to alexander-yakushev/official-images
that referenced
this pull request
Jul 21, 2024
alexander-yakushev
added a commit
to alexander-yakushev/official-images
that referenced
this pull request
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker usage on CI often needs git to perform auxiliary actions. For example, CircleCI doesn't checkout submodules by default. Given that tools.deps images already include
git(because tools.deps supports git-based dependencies), it makes sense to include one in Lein image for parity. It will also be useful for people who use something like https://github.com/reifyhealth/lein-git-down to download git-based deps in Lein.Practically for me, this will simplify and make more efficient the builds for https://github.com/clojure-emacs/orchard and https://github.com/clojure-emacs/cider-nrepl.