Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use less common name as match suffix #13

Merged
merged 2 commits into from
Nov 6, 2024
Merged

fix: Use less common name as match suffix #13

merged 2 commits into from
Nov 6, 2024
+4 −3

Conversation

MariusMerkleQC
Copy link
Contributor

@MariusMerkleQC MariusMerkleQC commented Nov 6, 2024 •
edited
Loading

Description

Solves #6.

Tasks

  • Try to understand where the issue comes from (one example)
  • Try to come up with a more unique name

Review

  • Feedback: Do you have any idea how to solve this more robustly?
  • Number of required reviews: 1, @borchero

@MariusMerkleQC MariusMerkleQC self-assigned this Nov 6, 2024
@github-actions github-actions bot added the fix label Nov 6, 2024
@MariusMerkleQC MariusMerkleQC marked this pull request as ready for review November 6, 2024 13:08
@borchero borchero merged commit 1cb5220 into main Nov 6, 2024
9 checks passed
@borchero borchero deleted the match_suffix branch November 6, 2024 16:26
@borchero borchero mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borchero borchero borchero approved these changes

Assignees

@MariusMerkleQC MariusMerkleQC

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MariusMerkleQC @borchero