Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI extension for new Corpus feature #499
UI extension for new Corpus feature #499
Changes from 41 commits
c793f2c
84bf47b
921a748
0dbad51
164a0ed
a84fa44
66170d9
361ea28
eeee6f1
f497abc
6e5bef1
be3b57f
69a7314
cdd466e
549a8d8
dee5e0e
1720e85
44e2ea5
88005a7
9917109
da398d1
97e0b70
3b582b3
68d2581
6ea9aa2
47a1991
36e790c
83e0120
f5b8c7f
ef44fb6
b2f5700
3889498
0b8b522
fc74e06
f3b0cb6
717dd3e
4d445dd
2220104
e813c2a
dfc0ecc
d6ff444
f4124c8
d40bc72
02cd14a
258160b
60419fe
b4b26df
df373f4
719082c
b8207f5
574d041
3d77da4
b7f39c0
99739b2
625a648
d85478d
95eeeee
f245f91
4e716a8
a095a1f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once #495 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be #500, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Display in right sidebar depending on what has been used as
input
for the chat.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed to reduce the number of resize operations on the height of the upload container (see previous comment on how I have introduced a new parameter for this). This has negligible UX impact IMO. The basic functionality was to make the upload container smaller when a 'pill' (icon for a newly upload file) was present below. I have now introduced some more spacing and a scroll (see below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduces wrapping so that if the pills are wider than the modal, they 'wrap' around to the next line, and scroll along the Y-axis. I have removed the scroll on the X-axis as I found having too scrolls to be hard to follow. I have also added more spacing to compensate for the fact that the file upload container no longer shrinks when a pill is added (see previous comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make things a bit more readable when many pills, introduce a small amount of white space between them.