Port away from deprecated API in Qt 6.6: QColor::setNamedColor #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfaure-kdab
force-pushed
the
wip/dfaure/qt6.6
branch
2 times, most recently
from
92595e3
to
b5e2e05
Compare
|
@dantti what's with the mac CI? It seems to mix up arm64 and x64, can't be related to this change.... |
|
hmm that's a known issue I had to deal with on other repos, GitHub now has AppleSilicon workers, so we need to say CMAKE_MACOS_ARCH='x86_64' for Qt5 since there was no open source arm support for mac., will do another PR to fix this... |
The replacement, QColor::fromString() exists since Qt 6.4.
dfaure-kdab
force-pushed
the
wip/dfaure/qt6.6
branch
from
b5e2e05
to
016a91c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replacement, QColor::fromString() exists since Qt 6.4.