Remove undefined CellReference::fromString

FIXES: #327
QtExcel · Sep 3, 2024 · 2ed9f1e · 2ed9f1e
1 parent 35c6d27
commit 2ed9f1e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/QXlsx/header/xlsxcellreference.h b/QXlsx/header/xlsxcellreference.h
@@ -7,10 +7,6 @@
 
 QT_BEGIN_NAMESPACE_XLSX
 
-const int XLSX_ROW_MAX    = 1048576;
-const int XLSX_COLUMN_MAX = 16384;
-const int XLSX_STRING_MAX = 32767;
-
 class QXLSX_EXPORT CellReference
 {
 public:
@@ -29,7 +25,6 @@ class QXLSX_EXPORT CellReference
     ~CellReference();
 
     QString toString(bool row_abs = false, bool col_abs = false) const;
-    static CellReference fromString(const QString &cell);
     bool isValid() const;
     inline void setRow(int row) { _row = row; }
     inline void setColumn(int col) { _column = col; }
@@ -47,7 +42,7 @@ class QXLSX_EXPORT CellReference
 
     inline bool operator>(const CellReference &other) const
     {
-        return _row > other._row ||  _column != other._column;
+        return _row > other._row || _column != other._column;
     }
 
 private:

diff --git a/QXlsx/source/xlsxworksheet.cpp b/QXlsx/source/xlsxworksheet.cpp
@@ -42,6 +42,12 @@
 
 QT_BEGIN_NAMESPACE_XLSX
 
+namespace name {
+const int XLSX_ROW_MAX    = 1048576;
+const int XLSX_COLUMN_MAX = 16384;
+const int XLSX_STRING_MAX = 32767;
+} // namespace name
+
 WorksheetPrivate::WorksheetPrivate(Worksheet *p, Worksheet::CreateFlag flag)
     : AbstractSheetPrivate(p, flag)
     , windowProtection(false)