Balance Recorder & Hard Forks #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the updated field is not getting updated
…nd kicking members and member ban cancellations; enforcing group approval thresholds to invites and invite cancellations; the established add and remove admin capabilities were used as guidance for this implementation; this was added as a hardfork to preserve group transactions from previous blocks
added seller/buyer to filter completed trades
…ated release which uses Groups for as a reserved word
…ade it under the assumption that it was used for reward distributions when it is used for block signatures only
…y testing environment and causes problems in production
…ow case-sensitive. Since it is now case-sensitive it needs to be in all caps, so when other SQL statements call on this table using the Groups without backticks it will be compatible. When Groups is used in a statement without back ticks or quotes it automatically gets converted into capital letters.
…dded some fail safes in case the admin groups are empty
…ved the fail-safe feature trigger since the ignore level feature trigger now satisfies it implicitly
crowetic
reviewed
Jan 16, 2025
There was a problem hiding this comment.
All changes have been being tested on devnet for a while, everything is working as expected.
Only thing necessary now is to set the featureTrigger block for the new triggers:
"adminsReplaceFoundersHeight": 9999999, "nullGroupMembershipHeight": 9999999, "ignoreLevelForRewardShareHeight": 9999999
I will do this as the auto-update preparation completes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Balance recorder implementation and 3 hard forks ... Admins Replace Founders, Null Group Membership and Ignore Level For Reward Share