Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Payment.java #234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Payment.java #234

wants to merge 1 commit into from

Conversation

infinitydaemon
Copy link

  • Removed redundant null check on ATData in isValid method.
  • Simplified isValid overloads by calling the same function with a singleton list for single payments, reducing code duplication.
  • Refined balance checks for fee and asset amount validity to improve clarity and correctness.

@infinitydaemon
Update Payment.java
4766dae 
* Removed redundant null check on ATData in isValid method.
* Simplified isValid overloads by calling the same function with a singleton list for single payments, reducing code duplication.
* Refined balance checks for fee and asset amount validity to improve clarity and correctness.
@QuickMythril
Copy link

Build errors due to removing isProcessable:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project qortal: Compilation failure: Compilation failure: 
[ERROR] qortal/src/main/java/org/qortal/transaction/ArbitraryTransaction.java:[256,52] cannot find symbol
[ERROR]   symbol:   method isProcessable(byte[],java.util.List<org.qortal.data.PaymentData>,java.lang.Long)
[ERROR]   location: class org.qortal.payment.Payment
[ERROR] qortal/src/main/java/org/qortal/transaction/MessageTransaction.java:[272,52] cannot find symbol
[ERROR]   symbol:   method isProcessable(byte[],org.qortal.data.PaymentData,java.lang.Long,boolean)
[ERROR]   location: class org.qortal.payment.Payment
[ERROR] qortal/src/main/java/org/qortal/transaction/MultiPaymentTransaction.java:[67,52] cannot find symbol
[ERROR]   symbol:   method isProcessable(byte[],java.util.List<org.qortal.data.PaymentData>,java.lang.Long)
[ERROR]   location: class org.qortal.payment.Payment
[ERROR] qortal/src/main/java/org/qortal/transaction/PaymentTransaction.java:[61,52] cannot find symbol
[ERROR]   symbol:   method isProcessable(byte[],org.qortal.data.PaymentData,java.lang.Long)
[ERROR]   location: class org.qortal.payment.Payment
[ERROR] qortal/src/main/java/org/qortal/transaction/TransferAssetTransaction.java:[70,52] cannot find symbol
[ERROR]   symbol:   method isProcessable(byte[],org.qortal.data.PaymentData,java.lang.Long)
[ERROR]   location: class org.qortal.payment.Payment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infinitydaemon @QuickMythril