Use workspace versioning and relax hashbrown/indexmap deps
#956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does two things: first, switch a lot of metadata-definition
to use the workspace-package inheritance allowed since Rust 1.64
(including several shared dependencies); second, relax the installation
requirements on `indexmap` and `hashbrown` to allow both to use their
most recent two majors. Dependents can then install `rustworkx-core`
using either (say) `hashbrown 0.13.2` or `hashbrown 0.14.0` as desired,
and similar between `indexmap 1.9.3` and `indexmap 2.0.0`.
This commit leaves the lock file in the `hashbrown 0.14.0`, `indexmap
2.0.0` state, although note that some other crate dependents still use
`hashbrown 0.12.3` internally, but this doesn't matter for the public
API surface. I tested it manually in the `hashbrown 0.13.2`, `indexmap
1.9.3` state by updating those two dependencies with:
cargo update -p '[email protected]' --precise 1.9.3
cargo update -p '[email protected]' --precise 0.13.2
cargo update -p '[email protected]'
|
It's probably possible to avoid allowing multiple versions of |
|
Last comment: I left the |
|
This is a good reminder that I forgot to forward port #929 to main. I did that on stable first for the 0.13.0 bugfix release and the msrv version constraint is lower on 0.13.x so we needed a wider hashmap range. |
|
Hahahaha, that's funny - I guess you can just close this PR if it's already done, then. |
|
Nah this pr is good, we need the fix on main too and this does it combined with more modern workspace usage. |
Pull Request Test Coverage Report for Build 5787373908
💛 - Coveralls |
IvanIsCoding
reviewed
Aug 1, 2023
IvanIsCoding
approved these changes
Aug 4, 2023
raynelfss
pushed a commit
to raynelfss/rustworkx
that referenced
this pull request
Aug 10, 2023
…t#956) This commit does two things: first, switch a lot of metadata-definition to use the workspace-package inheritance allowed since Rust 1.64 (including several shared dependencies); second, relax the installation requirements on `indexmap` and `hashbrown` to allow both to use their most recent two majors. Dependents can then install `rustworkx-core` using either (say) `hashbrown 0.13.2` or `hashbrown 0.14.0` as desired, and similar between `indexmap 1.9.3` and `indexmap 2.0.0`. This commit leaves the lock file in the `hashbrown 0.14.0`, `indexmap 2.0.0` state, although note that some other crate dependents still use `hashbrown 0.12.3` internally, but this doesn't matter for the public API surface. I tested it manually in the `hashbrown 0.13.2`, `indexmap 1.9.3` state by updating those two dependencies with: cargo update -p '[email protected]' --precise 1.9.3 cargo update -p '[email protected]' --precise 0.13.2 cargo update -p '[email protected]' Co-authored-by: Ivan Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does two things: first, switch a lot of metadata-definition to use the workspace-package inheritance allowed since Rust 1.64 (including several shared dependencies); second, relax the installation requirements on
indexmapandhashbrownto allow both to use their most recent two majors. Dependents can then installrustworkx-coreusing either (say)hashbrown 0.13.2orhashbrown 0.14.0as desired, and similar betweenindexmap 1.9.3andindexmap 2.0.0.This commit leaves the lock file in the
hashbrown 0.14.0,indexmap 2.0.0state, although note that some other crate dependents still usehashbrown 0.12.3internally, but this doesn't matter for the public API surface. I tested it manually in thehashbrown 0.13.2,indexmap 1.9.3state by updating those two dependencies with:This commit is kind of a proof-of-concept. I'm happy to split the different parts of it into a couple of different commits / PRs if preferred. I only did all the workspace stuff because it was more convenient for me when playing with the versions of packages - I'm totally happy to close this PR and reopen it in a couple of different bits.
Using this, I was able to build Qiskit against
rustworkx-core =0.14.0using bothhashbrown 0.13.2andhashbrown 0.14.0with a couple of suitablecargo updatecommands.Taken verbatim, this PR fixes #911 - it doesn't replace
hashbrown, but it does relax the version requirements.