-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of cycle_basis_edges #885
base: main
Are you sure you want to change the base?
Commits on Aug 11, 2023
-
Initial implementation of cycle_basis_edges
- Inspired from the existing procedure `cycle_basis`. - Modified to return a tuple of `NodeId` in format `(source, target)`. - Added API calls so that method works in Python.
Configuration menu - View commit details
-
Copy full SHA for 62f26f9 - Browse repository at this point
Copy the full SHA 62f26f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35eea7e - Browse repository at this point
Copy the full SHA 35eea7eView commit details -
Correction: Function returns EdgeIndex
- Cycle_basis_edges now returns a list of edgeIDs.
Configuration menu - View commit details
-
Copy full SHA for a8c1b67 - Browse repository at this point
Copy the full SHA a8c1b67View commit details -
Configuration menu - View commit details
-
Copy full SHA for c22c0b5 - Browse repository at this point
Copy the full SHA c22c0b5View commit details -
CI: Added python tests to test_cycle_basis.py
- Added `TestCycleBasisEdges` class for unit testing. - Added similar tests to those present on `TestCycleBasis`. - Tests are similar due to the same methodology. - Graphs used for testing are different.
Configuration menu - View commit details
-
Copy full SHA for c6dea4e - Browse repository at this point
Copy the full SHA c6dea4eView commit details -
Correction: get_edge_between checks target only
- Modified get_edge_between to only check target when equiv == false.
Configuration menu - View commit details
-
Copy full SHA for 23f2759 - Browse repository at this point
Copy the full SHA 23f2759View commit details -
Feature: merge basis and basis_edges into one
- Cycle basis edges is now within the codebase of cycle basis. - The `EdgesOrNodes` enum handles the different return data types.
Configuration menu - View commit details
-
Copy full SHA for dadb482 - Browse repository at this point
Copy the full SHA dadb482View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50d8685 - Browse repository at this point
Copy the full SHA 50d8685View commit details -
Docs: made changes to releasenotes and api.rst
- Release notes now include an example with a jupyter notebook.
Configuration menu - View commit details
-
Copy full SHA for 7c45634 - Browse repository at this point
Copy the full SHA 7c45634View commit details -
Fix: Make
cycle_basis
andEdgeOrNode
private- A previous commit inadvertedly made cycle_basis prublic. - To address this, two new public-facing functions were added: - `cycle_basis` for NodeId returns. - `cycle_basis_edges` for EdgeId returns. - When customizing cycle_basis a new enum EdgesOrNodes was made. - Enum should not be have been shared by definition. - Correction makes it private. - Removed redundant import from unwrap methods. - Tests have been adjusted accordingly.
Configuration menu - View commit details
-
Copy full SHA for c0f9f94 - Browse repository at this point
Copy the full SHA c0f9f94View commit details -
Configuration menu - View commit details
-
Copy full SHA for df5b3b5 - Browse repository at this point
Copy the full SHA df5b3b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26146af - Browse repository at this point
Copy the full SHA 26146afView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3f271a - Browse repository at this point
Copy the full SHA f3f271aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70541c8 - Browse repository at this point
Copy the full SHA 70541c8View commit details -
Correction:
get_edge_between
returnsEdgeId
.- The method returns the first edge found between nodes. - The docstring for this method was corrected.
Configuration menu - View commit details
-
Copy full SHA for dc7eb26 - Browse repository at this point
Copy the full SHA dc7eb26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38bdeac - Browse repository at this point
Copy the full SHA 38bdeacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 075b2f0 - Browse repository at this point
Copy the full SHA 075b2f0View commit details -
Fix: Pop unwrap warning by clippy.
- Use while let statement to continuously pop the queue.
Configuration menu - View commit details
-
Copy full SHA for 151a314 - Browse repository at this point
Copy the full SHA 151a314View commit details
Commits on Aug 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7f52970 - Browse repository at this point
Copy the full SHA 7f52970View commit details
Commits on Aug 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 10c16bf - Browse repository at this point
Copy the full SHA 10c16bfView commit details
Commits on Dec 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 62169b4 - Browse repository at this point
Copy the full SHA 62169b4View commit details
Commits on Jul 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6d11293 - Browse repository at this point
Copy the full SHA 6d11293View commit details