Read gzipped graphml files #1315
Conversation
|
|
|
Thanks for submitting this. I think this is a very welcoming addition. However, I don’t think we should have a new mehod to support compressed files. I’d refactor the existing method to try to decompress the file based on the file extension. And perhaps an optional argument like “force_decompression” to decompress anyway even if the file extension is not what we expect |
|
Ok I have now included everything in a single function, with the optional argument |
| pub fn read_graphml(py: Python, path: &str) -> PyResult<Vec<PyObject>> { | ||
| let graphml = GraphML::from_file(path)?; | ||
| #[pyo3(signature=(path, compression=""),text_signature = "(path, compression=\"\", /)")] | ||
| pub fn read_graphml(py: Python, path: &str, compression: &str) -> PyResult<Vec<PyObject>> { |
There was a problem hiding this comment.
Prefer Option<&str> over an empty string. For Python the default would become None which gets converted to None in Rust as well
There was a problem hiding this comment.
Yeah I thought about that too, but apparently it's being phased out:
https://pyo3.rs/main/function/signature#trailing-optional-arguments
There was a problem hiding this comment.
Yeah I thought about that too, but apparently it's being phased out: https://pyo3.rs/main/function/signature#trailing-optional-arguments
You just need to specify the None in the signature like you specified the empty string. We still use that in lots of places. What is deprecated is None being inserted by default without declaration
Create python function to load a graphml file that has been compressed with gzip without necessarily unzipping it before.
This makes reading large graphs in graphml much faster, and they can use less space
cargo clippyand it suggests no changes