-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add steiner tree functionality to rustworkx-core #1103
Merged
Merged
Commits on Feb 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 65043eb - Browse repository at this point
Copy the full SHA 65043ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for a718ee0 - Browse repository at this point
Copy the full SHA a718ee0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ba4b1d - Browse repository at this point
Copy the full SHA 2ba4b1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ee9fc6 - Browse repository at this point
Copy the full SHA 1ee9fc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for df973f3 - Browse repository at this point
Copy the full SHA df973f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86fdc60 - Browse repository at this point
Copy the full SHA 86fdc60View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad114be - Browse repository at this point
Copy the full SHA ad114beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5790bc3 - Browse repository at this point
Copy the full SHA 5790bc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 162a9fa - Browse repository at this point
Copy the full SHA 162a9faView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1e5457 - Browse repository at this point
Copy the full SHA f1e5457View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54d2d0e - Browse repository at this point
Copy the full SHA 54d2d0eView commit details -
This commit finishes the rustworkx-core port of the steiner tree and metric closure functions. In particular this was especially tricky because the petgraph traits make it exceedingly difficult to have a generic function that takes in a graph for analysis and modifies it as most of the traits required for visiting/iteration that are used for analysis are only defined on borrowed graphs, and the limited traits for modifying graphs are defined on owned graph types. This causes a conflict where you can't easily express that a generic type G created in a function from a user input is both mutated using a trait and analyzed as there is a type mismatch between G and &G. After spending far too long to fail to find a pattern to express this, I opted to just use a discrete type for the return and leave the actual graph mutation up to the rustworkx-core user because we're lacking the ability to cleanly express what is needed via petgraph.
Configuration menu - View commit details
-
Copy full SHA for 9ccdca1 - Browse repository at this point
Copy the full SHA 9ccdca1View commit details
Commits on Mar 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bca5c3e - Browse repository at this point
Copy the full SHA bca5c3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17d04d1 - Browse repository at this point
Copy the full SHA 17d04d1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.