-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FakeProviderForBackendV2.get_backend bug #8592
Fix FakeProviderForBackendV2.get_backend bug #8592
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2902618988
💛 - Coveralls |
Hi @HuangJunye, I am also interested in this fix. I think the test is not passing because in the assertion (line 37) the target for |
Hi, in regard to this PR, is it still feasible to include it or should one move towards the use of |
Sorry for keeping the this PR staled for so long. I think we can include it. I just need to add tests. I'll get to it next week |
Hi, could I cooperate to include this PR? |
@HuangJunye can you please update this branch so this bug can be fixed? |
Hi, one question, will be this PR included in the current dev branch?. The problem is still there, I can volunteer to help in there as I really need the fix. |
@acastanedam I accidentally deleted the branch. I have been wanted to finish this for a year but I get distracted with other things. I apologize for the delay. Can ask for your help to finish this? You can open a new PR and copy over the changes I have made so far and add tests. That should be enough to finish it. |
Summary
Previously,
FakeProviderForBackendV2.get_backend("fake_backend_name")
raises an error due to API change inBackendV2
. This PR fixes this bug.Fix #8531
Details and comments
get_backend
issueprovider.get_backend
syntaxtest_fake_provider.py