Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overhead for synthesized nodes lookup #13424

Merged
merged 1 commit into from
Nov 12, 2024

Commits on Nov 12, 2024

  1. Avoid overhead for synthesized nodes lookup

    After Qiskit#12550 a hash implementation was added to the implementation
    of DAGOpNode to be able to have identical instances of dag nodes used be
    usable in a set or dict. This is because after Qiskit#12550 changed the
    DAGCircuit so the DAGOpNode instances were just a python view of the
    data contained in the nodes of a dag. While prior to Qiskit#12550 the actual
    DAGOpNode objects were returned by reference from DAG methods. However,
    this hash implementation has additional overhead compared to the object
    identity based version used before. This has caused a regression in some
    cases for high level synthesis when it's checking for nodes it's already
    synthesized. This commit addresses this by changing the dict key to be
    the node id instead of the node object. The integer hashing is
    significantly faster than the object hashing.
    mtreinish committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b20e0a7 View commit details
    Browse the repository at this point in the history