-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oxidize the ConsolidateBlocks pass #13368
Merged
Merged
Commits on Oct 24, 2024
-
Oxidize the ConsolidateBlocks pass
This commit ports the consolidate blocks pass to rust. The logic remains the same and this is just a straight porting. One optimization is that to remove the amount of python processing the Collect2qBlocks pass is no longer run as part of the preset pass managers and this is called directly in rust. This speeds up the pass because it avoids 3 crossing of the language boundary and also the intermediate creation of DAGNode python objects. The pass still supports running with Collect2qBlocks for backwards compatibility and will skip running the pass equivalent internally the field is present in the property set. There are potential improvements that can be investigated here such as avoiding in place dag contraction and moving to rebuilding the dag iteratively. Also changing the logic around estimated error (see Qiskit#11659) to be more robust. But these can be left for follow up PRs as they change the logic. Realistically we should look at combining ConsolidateBlocks for it's current two usages with Split2qUnitaries and UnitarySynthesis into those passes for more efficiency. We can improve the performance and logic as part of that refactor. See Qiskit#12007 for more details on this for UnitarySynthesis. Closes Qiskit#12250
Configuration menu - View commit details
-
Copy full SHA for ed2b41b - Browse repository at this point
Copy the full SHA ed2b41bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 155a574 - Browse repository at this point
Copy the full SHA 155a574View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3e900b - Browse repository at this point
Copy the full SHA d3e900bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29bb569 - Browse repository at this point
Copy the full SHA 29bb569View commit details -
Configuration menu - View commit details
-
Copy full SHA for e50fc1c - Browse repository at this point
Copy the full SHA e50fc1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8da1b2f - Browse repository at this point
Copy the full SHA 8da1b2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61b831f - Browse repository at this point
Copy the full SHA 61b831fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55523bb - Browse repository at this point
Copy the full SHA 55523bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51fa6a5 - Browse repository at this point
Copy the full SHA 51fa6a5View commit details -
Remove release note and test change
The test failure fixed by a test change was incorrect and masked a logic bug that was fixed in a subsequent commit. This commit reverts that change to the test and removes the release note attempting to document a fix for a bug that only existed during development of this PR.
Configuration menu - View commit details
-
Copy full SHA for 8c43f01 - Browse repository at this point
Copy the full SHA 8c43f01View commit details -
Configuration menu - View commit details
-
Copy full SHA for b93df76 - Browse repository at this point
Copy the full SHA b93df76View commit details
Commits on Oct 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0423d1c - Browse repository at this point
Copy the full SHA 0423d1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8841f2 - Browse repository at this point
Copy the full SHA f8841f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 700814e - Browse repository at this point
Copy the full SHA 700814eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c4c50f - Browse repository at this point
Copy the full SHA 5c4c50fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a422990 - Browse repository at this point
Copy the full SHA a422990View commit details -
Optimize linalg in block collection
This commit reworks the logic to reduce the number of Kronecker products and 2q matrix multiplications we do as part of computing the unitary of the block. It now computes the 1q components individually with 1q matrix multiplications and only calls kron() and a 2q matmul when a 2q gate is encountered. This reduces the number of more expensive operations we need to perform and replaces them with a much faster 1q matmul.
Configuration menu - View commit details
-
Copy full SHA for 62df015 - Browse repository at this point
Copy the full SHA 62df015View commit details -
Configuration menu - View commit details
-
Copy full SHA for e001bab - Browse repository at this point
Copy the full SHA e001babView commit details
Commits on Nov 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 73fae86 - Browse repository at this point
Copy the full SHA 73fae86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 864fc51 - Browse repository at this point
Copy the full SHA 864fc51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11742b4 - Browse repository at this point
Copy the full SHA 11742b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1e645f - Browse repository at this point
Copy the full SHA f1e645fView commit details -
Apply suggestions from code review
Co-authored-by: Kevin Hartman <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b00e22c - Browse repository at this point
Copy the full SHA b00e22cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5b0172 - Browse repository at this point
Copy the full SHA b5b0172View commit details -
Configuration menu - View commit details
-
Copy full SHA for 223bf2e - Browse repository at this point
Copy the full SHA 223bf2eView commit details -
Reuse block_qargs for each block
Co-authored-by: Henry Zou <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b6071ee - Browse repository at this point
Copy the full SHA b6071eeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.